[WIP] Allow openvpn and transmission to be controlled by env var #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves about 49mb from the final image.
* save_space: Save space by combining all apt commands into a single RUN statement.
This was referenced May 9, 2015
ianneub
changed the title
|
Hey. This looks great! Really good solution to externalizing the configuration and dropping /config volume. Awesome! If you could make submit this PR into the dev branch, that would be great! Then we could both test it altogether and merge to master when its verified? The dev branch will also be built automatically and has tag dev in the registry. https://registry.hub.docker.com/u/haugene/transmission-openvpn/builds_history/80605/ |
|
Sounds good. Closing and will reopen against |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rolls up all my changes so far and supersedes #6 and #7.
With this PR, the openvpn/PIA end point and login credentials can get specified via ENV VARs. As well as all transmission settings.
It also includes the changes to save docker image space from #6.
Let me know if you'd like me to rebase this to one commit. Or if you want me to break it apart into multiple PRs.