Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IVPN support #73

Merged
merged 5 commits into from
May 11, 2016
Merged

Added IVPN support #73

merged 5 commits into from
May 11, 2016

Conversation

aaronblair
Copy link
Contributor

Didn't end up creating separate certificates as they were embedded directly in the ovpn files. Works perfectly on my machine.

@haugene
Copy link
Owner

haugene commented May 9, 2016

Sweet 👍 This looks good! Just a couple of comments. You should also update the OPENVPN_PROVIDER config section of the README, just add IVPN as a valid option. At least I've been doing it so far. We'll see what happens when the list gets too long :)

Also, did you use the "adjustConfigs.sh" script to modify the .ovpn files? If you see my last commits on the dev branch I've moved the up/down part of the config into a launch option for openvpn, so it no longer needs to be inserted into each .ovpn file.

If you update your PR with this, I'm looking forward to merging a new provider!

@aaronblair
Copy link
Contributor Author

No problem. I'll try to change that around tonight when I get home. I believe I used the adjustConfigs.sh before you made that change. Also, I'll break out the keys to their own files as it's definitely a cleaner way of doing it.

@aaronblair
Copy link
Contributor Author

I re-updated the ovpn files with the latest of your script and added IVPN to the OPENVPN_PROVIDER list.

Additionally, I made a couple compatibility changes to the "adjustConfigs.sh" script itself so that it will work on both BSD and Linux flavours. Changing to double square brackets is the only potential risk as it doesn't work with legacy SH (BASH, ZSH, etc are fine). See the relevant articles from stackoverflow on the SED change and the double bracket change.

@haugene
Copy link
Owner

haugene commented May 11, 2016

Great stuff! LGTM

Merging this do dev now. I'm just gonna update the instructions in the readme for how to add a new provider. It changed slightly since the up/down script was set up inside the .ovpn files, as you well know :) It'll be available with the dev tag and I'll merge it to master within the week.

Thanks for your contribution!

@haugene haugene merged commit c7db7b3 into haugene:dev May 11, 2016
@aaronblair aaronblair deleted the dev branch October 1, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants