Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IronSocket OVPN files #508

Merged
merged 5 commits into from
May 12, 2018
Merged

Added IronSocket OVPN files #508

merged 5 commits into from
May 12, 2018

Conversation

brossow
Copy link

@brossow brossow commented May 11, 2018

Added IronSocket OVPN files from https://ironsocket.com/network#ovpn (current as of 2018-05-11)

dev-type tun
nobind
persist-key
auth-user-pass
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haugene
Copy link
Owner

haugene commented May 11, 2018

Hey and thanks for creating this PR. Have you tested it locally?

I've added a comment in one of the ovpn files, you need to make it read the login credentials from a file like the other configs. Same goes for all the other files.

Doesn't look like you have to do more than that to make it work, all certificates seems to be inlined in the config files. Should also update README and add a default.ovpn symlink like the other providers.

Brent Rossow added 3 commits May 11, 2018 13:56
2. Updated 'ca', 'cert', 'key' and 'tls-cert' to read from files to simplify future maintenance
3. Added default.ovpn pointing to United-Kingdom.ovpn
4. Updated README to include IronSocket in the list of supported providers

Original OVPN files sourced directly from IronSocket at https://ironsocket.com/network#ovpn
2. Updated 'ca', 'cert', 'key' and 'tls-cert' to read from files to simplify future maintenance
3. Added default.ovpn pointing to United-Kingdom.ovpn
4. Updated README to include IronSocket in the list of supported providers

Original OVPN files sourced directly from IronSocket at https://ironsocket.com/network#ovpn
@brossow
Copy link
Author

brossow commented May 11, 2018

@haugene Please take a look at my changes at your convenience and let me know if anything else should be changed. I'm very new to this but work well with examples. As mentioned in the commits, I did the following:

  1. Updated 'auth-user-pass' to read login credentials from a file
  2. Updated 'ca', 'cert', 'key' and 'tls-cert' to read from files to simplify future maintenance
  3. Added default.ovpn pointing to United-Kingdom.ovpn
  4. Updated README to include IronSocket in the list of supported providers

I haven't tested these myself (I have yet to even install the container) but took this on because I need the IronSocket support). My hope is that getting IronSocket into the dev branch would at least give a head start to someone who knows what s/he's doing to tweak as needed. 🙂

@haugene
Copy link
Owner

haugene commented May 12, 2018

Hello again. The changes looks great. Merging to dev now. Please let me know if you get it working :)
Thanks for contributing!

@haugene haugene merged commit 68ee253 into haugene:dev May 12, 2018
@brossow
Copy link
Author

brossow commented May 21, 2018

@haugene Just wanted to let you know that I finally got around to installing this today from the dev branch. Transmission and the new Ironsocket VPN stuff I added are working great on my Synology (thanks to the tips on issue #41).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants