Transmission home mountpoint set to /config

[pkishino]

Breaking change

This changes default mountpoint for transmission-home to /config in line with proper configurations.
if other mount point is set in env variables, a warning will be logged (it will still work but not recommended)

Proposed change

Change default mount for transmission-home to /config, see issue linked

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality to a this container)
• Breaking change (fix/feature causing existing functionality to break)

Additional information

• This PR fixes or closes issue: fixes transmission-home created within /data folder #1521
• This PR is related to issue: relates to #
• Link to documentation updated (if done separately): https://...

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated

[haugene]

I think many people have not mounted /config. So doing a mv will possibly move the home folder to a non-mounted file system within the container and it would be gone when the container is re-created.

I know that's not 100% true because we specify VOLUME /config in the Dockerfile, but... For a new Docker-user it's probably tricky to re-locate their transmission-home inside a volume.

[pkishino]

Right now, if user has not set TRANSMISSION_HOME_MIGRATE then only the warning is shown..
While it makes more sense to keep it under /config… I’m not against a user saying they don’t want that etc..
this would mainly affect new installs and optionally the user can let the system migrate it for them..
Perhaps add another check to see if the user has mounted /config or not?

[haugene]

Ah, sorry. I was a bit quick there, hadn't read it properly it seems 🙈
EDIT: And then I did it again, not reading all the code. I'm signing off for now, but the gist of what I was trying to communicate is...

If we change the default TRANSMISSION_HOME value in our Dockerfile I think most users will come to a blank Transmission state after they re-create the image next time (it will still be in /data though). The NAS gang usually has TRANSMISSION_HOME set because they get all the env vars in their GUI, but I would expect most of the rest to not have the env var set and just rely on the default.

If I'm not mistaken about the fallout here, then that's a bit too much breakage IMO. So I think we have to look for /data/transmission-home and then use that if it exists and log that they are using a non-default setup.

[pkishino]

Ah, yes, I ate and I’ll fix a fallback after the little one has been dropped off at dagis ;)

[haugene]

I agree that this data should live under /config. But we need to make the transition a bit smoother I think. Ref my comment on the userSetup.sh script. Could we symlink? Could we check if /config is mounted?

I'm more comfortable with a hard error telling the user to mount /config than moving user data without the user knowing.
We could link them to a page (gist or anything) saying "stop the container", "do docker cp .. ..", mount this/that and start again.
But I think this will lead to a lot of noise for a while 🙈

Should we do 5.0 release and then just hard-error telling people to revert to 4.x or fix their mounts? I'm not sure here.

[pkishino]

We wouldn’t be moving anything without the user explicitly saying so.. and I’m not sure I agree on the hard stop. In the end it should be up to the user how they want to set it up etc, but our recommended setup has a mount for /config in user land moving forward, as it makes more sense to keep config there.. but I don’t see any problems or such of the user wants to keep the current setup