Bind transmission IPv4 address #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt.sh in the repo too. Updated all piaconfigs to force tun0
…n to bind to it. Closes #11
Bind transmission to tun0
|
Yeah, and because of the minor change in our "API" by removing KEEP_TRANSMISSION_STATE functionality I'm bumping to 1.1 |
|
I think that's a great idea. LGTM 👍 |
haugene
added a commit
that referenced
this pull request
May 27, 2015
Bind transmission IPv4 address. Minor changes in run options, bump to version 1.1
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the /data/transmission-daemon option, and it cleans things up a bit.
Tried to move the dockerize templating to transmission startup script but the env vars weren't accessible in the transmission user. So now I write them to a file on container startup, and source them into the shell that starts transmission.
I felt it looked cleaner to let the transmission start script handle settings.json generation. And then dockerize handles it all, instead of manually regex'ing the settings.
Any thoughts @ianneub ?