Increase healthcheck ping timeout #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this issue with VPNUnlimited as provider. |
pkishino
added a commit
that referenced
this pull request
Feb 12, 2021
* Brush up proxy and rss plugin images, build for multiarch support #1483 * Escape special characters in rss-plugin input variables #1565 * Increase healthcheck ping timeout (#1627) * Add DNS resolution checks (fix #1608) (#1617) * Add dns resolution test to healthcheck script * Add dns resolution test to start script Co-authored-by: Patrick Kishino <[email protected]> * Fix PIA infinite redirect on config download (see #1619) (#1620) PIA download link was redirecting and setting a cookie, but those are disabled by default unless `--cookie` or `--cookie-jar` are given. Since the cookie was not set, the redirection was attempted again until we reached the maximum redirection limit. The `--cookie /dev/null` specifies an empty input cookie, which has the effect to enable curl's handling of cookies. Co-authored-by: Kristian Haugene <[email protected]> Co-authored-by: clement-z <[email protected]>
steveneighbour
pushed a commit
to steveneighbour/openvpn
that referenced
this pull request
Apr 17, 2021
steveneighbour
pushed a commit
to steveneighbour/openvpn
that referenced
this pull request
Apr 17, 2021
* Brush up proxy and rss plugin images, build for multiarch support haugene#1483 * Escape special characters in rss-plugin input variables haugene#1565 * Increase healthcheck ping timeout (haugene#1627) * Add DNS resolution checks (fix haugene#1608) (haugene#1617) * Add dns resolution test to healthcheck script * Add dns resolution test to start script Co-authored-by: Patrick Kishino <[email protected]> * Fix PIA infinite redirect on config download (see haugene#1619) (haugene#1620) PIA download link was redirecting and setting a cookie, but those are disabled by default unless `--cookie` or `--cookie-jar` are given. Since the cookie was not set, the redirection was attempted again until we reached the maximum redirection limit. The `--cookie /dev/null` specifies an empty input cookie, which has the effect to enable curl's handling of cookies. Co-authored-by: Kristian Haugene <[email protected]> Co-authored-by: clement-z <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1582
For some reason, a 5 seconds timeout on ping specified as
-w 5is sometimes too short for two pings to go through, most likely because of the delay between pings and...? I don't know, but it nevertheless causes some apparent ping loss, as the last ping is deemed unsuccessful. This in turn marks the container as unhealthy even when it is indeed connected to the VPN and able to reach the internet.I just increased the timeout to 10 seconds (for 2 pings). This seems awfully long for 2 small pings, but 🤷