Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #15

Merged
merged 3 commits into from
May 20, 2015
Merged

Update README.md #15

merged 3 commits into from
May 20, 2015

Conversation

pyle
Copy link
Contributor

@pyle pyle commented May 18, 2015

Updated section on using nginx proxy -

container nginx .conf location was incorrect.
container nginx port mapping was incorrect
The changes were made to work with existing transmission container

Updated section on using nginx proxy - 
> container nginx .conf location was incorrect.
> container nginx port mapping was incorrect
The changes were made to work with existing transmission container
@@ -92,7 +92,7 @@ This is because the VPN is active, and since docker is running in a different ip
There are several ways to fix this. You can pipe and do fancy iptables or ip route configurations on the host and in the Docker image. But I found that the simplest solution is just to proxy my traffic. Start a Nginx container like this:

```
$ docker run -d -v /path/to/nginx.conf:/etc/nginx.conf:ro -p 8080:80 nginx
$ docker run -d -v /path/to/nginx.conf:/etc/nginx/nginx.conf:ro -p 8080:8080 nginx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right about the path, but my example config listed below listens on port 8080. So update with port 8080 and I merge.

Updated port mapping back to default
@pyle
Copy link
Contributor Author

pyle commented May 20, 2015

@haugene Made revisions to the Readme RE: nginx

@haugene
Copy link
Owner

haugene commented May 20, 2015

Awwww, you were completely right the first time. It's supposed to be 8080:8080. I don't know what I was thinking. Can you revert your last commit? Sorry about the back and forth.

Fixed minor port mistake
@pyle
Copy link
Contributor Author

pyle commented May 20, 2015

@haugene All fixed.
I also changed the readme with out testing the new theory. All should be right now.

Cheers for the awesome container, works a treat

haugene added a commit that referenced this pull request May 20, 2015
@haugene haugene merged commit 447ec74 into haugene:master May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants