Control PIA and Transmission from env vars #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianneub
changed the title
ianneub
changed the title
|
Ok I think this is ready to go now. Phew, sorry for all the clutter. I messed up the rebase/merging. But everything should be good now, and it's all condensed into one commit 👍 |
ianneub
changed the title
ianneub
force-pushed
the
dev
branch
2 times, most recently
from
bbe57d0 to
76935c0
Compare
| echo $PIA_USERNAME > /config/pia-credentials.txt | ||
| echo $PIA_PASSWORD >> /config/pia-credentials.txt | ||
| else | ||
| echo "Not setting PIA credentials." |
There was a problem hiding this comment.
Should probably not allow startup without credentials. Thinking exit here...
|
Left some notes, I'm gonna do a little refactor. But good, merging now! |
haugene
added a commit
that referenced
this pull request
May 10, 2015
Control PIA and Transmission from env vars
| @@ -36,9 +28,81 @@ ADD transmission/runUpdates.sh /etc/transmission-daemon/startPortUpdates.sh | |||
| ADD transmission/down.sh /etc/transmission-daemon/stop.sh | |||
| ADD runOpenVpn.sh /etc/openvpn/start.sh | |||
|
|
|||
| ENV PIA_USERNAME=**None** \ | |||
| PIA_PASSWORD=**None** \ | |||
There was a problem hiding this comment.
I also set these to a default bogus value. You can remove these as well if you'd like.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reducing size of Docker image.