Change eslint rule no-nested-ternary from warn to off

hato-org · Dec 7, 2024 · 8281b63 · 8281b63
1 parent dadae40
commit 8281b63
Show file tree

Hide file tree

Showing 13 changed files with 60 additions and 89 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -42,7 +42,7 @@
     "@typescript-eslint/no-use-before-define": "off",
     "no-underscore-dangle": "off",
     "no-console": "warn",
-    "no-nested-ternary": "warn",
+    "no-nested-ternary": "off",
     "import/extensions": "off",
     "import/prefer-default-export": "off"
   }

diff --git a/src/@types/transit.d.ts b/src/@types/transit.d.ts
@@ -24,9 +24,11 @@ interface DiaInfo {
 interface TransitTimetable {
   starting: string;
   destination: string;
-  stations: {
-    name: string;
-    arriveAt?: string;
-    departAt?: string;
-  }[];
+  stations: TransitTimetableStation[];
 }
+
+interface TransitTimetableStation {
+  name: string;
+  arriveAt?: string;
+  departAt?: string;
+}
diff --git a/src/components/calendar/Calendar.tsx b/src/components/calendar/Calendar.tsx
@@ -91,15 +91,13 @@ const Calendar = React.memo(
                     >
                       <Text
                         color={
-                          /* eslint-disable no-nested-ternary */
                           isSameMonth(date, day)
                             ? isSaturday(day)
                               ? 'blue.400'
                               : isSunday(day)
                                 ? 'red.400'
                                 : 'title'
                             : 'description'
-                          /* eslint-enable no-nested-ternary */
                         }
                         textStyle="title"
                         fontSize="xs"
@@ -141,37 +139,31 @@ const Calendar = React.memo(
                               px={{ base: 0, md: '2px' }}
                               py={{ base: 0, md: '1px' }}
                               bg={
-                                /* eslint-disable no-nested-ternary */
                                 event.external
                                   ? event.isAllDay
                                     ? 'green.400'
                                     : 'green.50'
                                   : event.isAllDay
                                     ? 'blue.400'
                                     : 'blue.50'
-                                /* eslint-enable no-nested-ternary */
                               }
                               color={
-                                /* eslint-disable no-nested-ternary */
                                 event.external
                                   ? event.isAllDay
                                     ? 'white'
                                     : 'green.400'
                                   : event.isAllDay
                                     ? 'white'
                                     : 'blue.400'
-                                /* eslint-enable no-nested-ternary */
                               }
                               _hover={{
-                                /* eslint-disable no-nested-ternary */
                                 bg: event.external
                                   ? event.isAllDay
                                     ? 'green.500'
                                     : 'green.100'
                                   : event.isAllDay
                                     ? 'blue.500'
                                     : 'blue.100',
-                                /* eslint-enable no-nested-ternary */
                               }}
                               transition="all .2s ease"
                               as={RouterLink}

diff --git a/src/components/cards/Timetable.tsx b/src/components/cards/Timetable.tsx
@@ -90,7 +90,6 @@ function Timetable() {
         ) : (
           <Error type="userScheduleNotSet" />
         )}
-        {/* eslint-enable no-nested-ternary */}
       </VStack>
       <DivisionEditor date={date} isOpen={isOpen} onClose={onClose} />
     </>

diff --git a/src/components/classmatch/MetaEditor.tsx b/src/components/classmatch/MetaEditor.tsx
@@ -64,7 +64,6 @@ function MetaEditor({
       <Text textStyle="description" fontWeight="bold" fontSize="xs">
         試合結果
       </Text>
-      {/* eslint-disable no-nested-ternary */}
       <Box w="full" pos="relative">
         {!isParticipantsEditable && (
           <Center
@@ -238,13 +237,11 @@ function ClassSelectMenu({
         rightIcon={<Icon as={TbChevronDown} />}
         textStyle={currentClass?.from ? 'title' : 'description'}
       >
-        {/* eslint-disable no-nested-ternary */}
         {currentClass?.from
           ? currentClass.type === 'teacher'
             ? '職員'
             : `${currentClass.grade}-${currentClass.class}`
           : 'クラス'}
-        {/* eslint-enable no-nested-ternary */}
       </MenuButton>
       <Box>
         <MenuList rounded="xl" shadow="xl">
@@ -300,15 +297,13 @@ function ClassSelectMenuItem({
         })
       }
     >
-      {/* eslint-disable no-nested-ternary */}
       {tournament.class
         ? tournament.class.type === 'teacher'
           ? '職員'
           : `${tournament.class.grade}-${tournament.class.class}`
         : winner.type === 'teacher'
           ? '職員'
           : `${winner.grade}-${winner.class}`}
-      {/* eslint-enable no-nested-ternary */}
     </MenuItem>
   );
 }

diff --git a/src/components/library/Search.tsx b/src/components/library/Search.tsx
@@ -123,7 +123,6 @@ const SearchResult = React.memo(
   }) => (
     <Box w="100%" h="100%">
       <Collapse in={!!result || isLoading}>
-        {/* eslint-disable no-nested-ternary */}
         {isLoading ? (
           <Loading />
         ) : result?.count ? (
@@ -178,7 +177,6 @@ const SearchResult = React.memo(
             </Text>
           </VStack>
         )}
-        {/* eslint-enable no-nested-ternary */}
       </Collapse>
     </Box>
   ),

diff --git a/src/components/nav/SideMenu.tsx b/src/components/nav/SideMenu.tsx
@@ -184,66 +184,63 @@ const MenuBody = React.memo(() => {
           </Heading>
         )}
       </HStack>
-      {menu.map(
-        (menuItem, index) =>
-          /* eslint-disable no-nested-ternary */
-          menuItem.type === 'divider' ? (
-            <StackDivider
-              // eslint-disable-next-line react/no-array-index-key
-              key={`${menuItem.type}-${index}`}
-              borderWidth="1px"
-              borderColor="border"
-            />
-          ) : breakPoint === 1 ? (
-            <IconButton
-              aria-label={menuItem.label}
-              icon={menuItem.icon}
-              size="lg"
-              variant="ghost"
-              isRound
+      {menu.map((menuItem, index) =>
+        menuItem.type === 'divider' ? (
+          <StackDivider
+            // eslint-disable-next-line react/no-array-index-key
+            key={`${menuItem.type}-${index}`}
+            borderWidth="1px"
+            borderColor="border"
+          />
+        ) : breakPoint === 1 ? (
+          <IconButton
+            aria-label={menuItem.label}
+            icon={menuItem.icon}
+            size="lg"
+            variant="ghost"
+            isRound
+            color={
+              menuItem.color ??
+              (location.pathname === menuItem.href ? 'blue.400' : undefined)
+            }
+            as={RouterLink}
+            to={menuItem.href}
+            onClick={
+              menuItem.onClick as unknown as React.MouseEventHandler<HTMLButtonElement>
+            }
+          />
+        ) : (
+          <HStack
+            p={2}
+            key={menuItem.label}
+            w="100%"
+            spacing={4}
+            color={
+              location.pathname.startsWith(menuItem.href)
+                ? 'blue.400'
+                : undefined
+            }
+            layerStyle="button"
+            rounded="xl"
+            as={RouterLink}
+            to={menuItem.href}
+            {...menuItem}
+          >
+            {menuItem.icon}
+            <Text
               color={
                 menuItem.color ??
-                (location.pathname === menuItem.href ? 'blue.400' : undefined)
-              }
-              as={RouterLink}
-              to={menuItem.href}
-              onClick={
-                menuItem.onClick as unknown as React.MouseEventHandler<HTMLButtonElement>
-              }
-            />
-          ) : (
-            <HStack
-              p={2}
-              key={menuItem.label}
-              w="100%"
-              spacing={4}
-              color={
-                location.pathname.startsWith(menuItem.href)
+                (location.pathname.startsWith(menuItem.href)
                   ? 'blue.400'
-                  : undefined
+                  : undefined)
               }
-              layerStyle="button"
-              rounded="xl"
-              as={RouterLink}
-              to={menuItem.href}
-              {...menuItem}
+              textStyle="title"
+              fontSize="lg"
             >
-              {menuItem.icon}
-              <Text
-                color={
-                  menuItem.color ??
-                  (location.pathname.startsWith(menuItem.href)
-                    ? 'blue.400'
-                    : undefined)
-                }
-                textStyle="title"
-                fontSize="lg"
-              >
-                {menuItem.label}
-              </Text>
-            </HStack>
-          ),
-        /* eslint-enable no-nested-ternary */
+              {menuItem.label}
+            </Text>
+          </HStack>
+        ),
       )}
       <Spacer />
       <Account />

diff --git a/src/components/posts/PDFViewer.tsx b/src/components/posts/PDFViewer.tsx
@@ -96,7 +96,6 @@ const PDFViewer = React.memo(
           </DrawerHeader>
           <DrawerBody p={0} position="relative" zIndex={-5}>
             <Center>
-              {/* eslint-disable no-nested-ternary */}
               {isPending ? (
                 <Loading />
               ) : error ? (
@@ -128,7 +127,6 @@ const PDFViewer = React.memo(
                   ))}
                 </Document>
               )}
-              {/* eslint-enable no-nested-ternary */}
             </Center>
           </DrawerBody>
         </DrawerContent>

diff --git a/src/components/timetable/editor/UserSubjectPicker.tsx b/src/components/timetable/editor/UserSubjectPicker.tsx
@@ -150,7 +150,6 @@ const UserSubjectPicker = React.memo(
                 onClick={(e) => e.stopPropagation()}
                 w="full"
               >
-                {/* eslint-disable no-nested-ternary */}
                 {searchPending ? (
                   <Loading />
                 ) : searchResult?.length ? (
@@ -177,7 +176,6 @@ const UserSubjectPicker = React.memo(
                     候補がありません
                   </Text>
                 )}
-                {/* eslint-enable no-nested-ternary */}
               </VStack>
             </VStack>
           </ModalBody>

diff --git a/src/components/transit/DiaStatus.tsx b/src/components/transit/DiaStatus.tsx
@@ -38,7 +38,6 @@ const DiaStatus = React.memo(() => {
       </Text>
       <Skeleton w="100%" minH={8} rounded="xl" isLoaded={!isPending}>
         <Center w="full">
-          {/* eslint-disable no-nested-ternary */}
           {error ? (
             <Error error={error} />
           ) : unstableLines?.length ? (
@@ -51,7 +50,6 @@ const DiaStatus = React.memo(() => {
               全路線平常運転
             </Text>
           )}
-          {/* eslint-enable no-nested-ternary */}
         </Center>
       </Skeleton>
     </VStack>

diff --git a/src/pages/Timetable.tsx b/src/pages/Timetable.tsx
@@ -175,7 +175,6 @@ function Timetable() {
                     </HStack>
                     <Icon as={TbChevronRight} />
                   </HStack>
-                  {/* eslint-disable no-nested-ternary */}
                   {user.userScheduleId ? (
                     division ? (
                       <TimetableTable
@@ -196,7 +195,6 @@ function Timetable() {
                   ) : (
                     <Error type="userScheduleNotSet" />
                   )}
-                  {/* eslint-enable no-nested-ternary */}
                 </VStack>
                 {/* <StackDivider borderWidth="1px" /> */}
                 <HStack w="100%">

diff --git a/src/pages/classroom/Classroom.tsx b/src/pages/classroom/Classroom.tsx
@@ -116,7 +116,6 @@ export default function Classroom() {
         }
       >
         <Box px={4} mb={24}>
-          {/* eslint-disable no-nested-ternary */}
           {isLoading ? (
             <Loading withTips initialTip={0} />
           ) : error ? (
@@ -145,7 +144,6 @@ export default function Classroom() {
               useWindowScroll
             />
           )}
-          {/* eslint-enable no-nested-ternary */}
         </Box>
       </ChakraPullToRefresh>
     </Box>

diff --git a/src/pages/classroom/ClassroomCourse.tsx b/src/pages/classroom/ClassroomCourse.tsx
@@ -78,7 +78,6 @@ export default function ClassroomCourse() {
       >
         <VStack p={4} mb={24}>
           <CourseHeader courseId={id} />
-          {/* eslint-disable no-nested-ternary */}
           {isLoading ? (
             <Loading withTips initialTip={0} />
           ) : error ? (
@@ -107,7 +106,6 @@ export default function ClassroomCourse() {
               useWindowScroll
             />
           )}
-          {/* eslint-enable no-nested-ternary */}
         </VStack>
       </ChakraPullToRefresh>
     </>