Add renesas ra8 support. #2601
Open
Add renesas ra8 support. #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbb666
commented
Apr 16, 2024
| @@ -48,6 +48,7 @@ extern "C" { | |||
| /* Start of definition of packed structs (used by the CCRX toolchain) */ | |||
| TU_ATTR_PACKED_BEGIN | |||
| TU_ATTR_BIT_FIELD_ORDER_BEGIN | |||
| #pragma pack(2) | |||
There was a problem hiding this comment.
I found that using the armclang compiler(ac6) without adding this code will cause it to not run properly.
There was a problem hiding this comment.
If pack is wrong it should be fixed in src/common/tusb_compiler.h
HiFiPhile
reviewed
Apr 16, 2024
| @@ -356,6 +356,7 @@ | |||
| #elif TU_CHECK_MCU(OPT_MCU_RX63X, OPT_MCU_RX65X, OPT_MCU_RX72N, OPT_MCU_RAXXX) | |||
| #define TUP_USBIP_RUSB2 | |||
| #define TUP_DCD_ENDPOINT_MAX 10 | |||
| #define TUP_RHPORT_HIGHSPEED 1 | |||
There was a problem hiding this comment.
You need to put this statement inside conditional check as other MCUs don't support HS. For example #if defined(BSP_MCU_GROUP_RA8M1)
hathach
reviewed
Apr 16, 2024
hathach
requested changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add renesas cortex-m85 ra8 support.
Additional context
If applicable, add any other context about the PR and/or screenshots here.