Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update video_capture #2428

Merged
merged 7 commits into from
Jan 30, 2024
Merged

update video_capture #2428

merged 7 commits into from
Jan 30, 2024

Conversation

YixingShen
Copy link
Contributor

  1. add tx_busy = 1 into examples/device/video_capture/src/main.c because "if (tx_busy)" is always false.
  2. Correct VIDEO_CS_VS_INTERFACE_FRAME_MJPEG to VIDEO_CS_ITF_VS_FRAME_MJPEG for #define TUD_VIDEO_DESC_CS_VS_FRM_MJPEG_DISC

@kkitayam
Copy link
Collaborator

Thank you for fixing tx_busy. It looks good for me. But I am not familiar with stm32f1, so I cannot comment on the changing related to it.

@kkitayam kkitayam requested a review from hathach January 29, 2024 14:21
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert the change in the f1 family.c since it break compile with other f1 that does not use UART.

hw/bsp/stm32f1/family.c Outdated Show resolved Hide resolved
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix

@hathach hathach merged commit 7a92038 into hathach:master Jan 30, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants