Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rp2040: include hardware/sync.h explicitly #1948

Merged
merged 1 commit into from
Mar 11, 2023
Merged

rp2040: include hardware/sync.h explicitly #1948

merged 1 commit into from
Mar 11, 2023

Conversation

dhalbert
Copy link
Contributor

tinyusb/src/portable/raspberrypi/rp2040/dcd_rp2040.c

Line 300 in 990fb6a

uint8_t const * setup = remove_volatile_cast(uint8_t const*, &usb_dpram->setup_packet);

dcd_rp2040.c uses remove_volatile_cast(), which is defined in the pico-sdk in hardware/sync.h. But dcd_rp2040.c does not #include hardware/sync.h. When not using the pico-sdk build environment and OSAL_PICO, remove_volatile_cast() will not be defined. This PR adds an explicit #include to fix that.

hathach
hathach approved these changes Mar 11, 2023
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank Danh

@hathach hathach merged commit be21413 into hathach:master Mar 11, 2023
@dhalbert dhalbert mentioned this pull request Mar 11, 2023
Merged
@dhalbert dhalbert deleted the remove-volatile-cast-include branch March 12, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove_volatile_cast() not available in src/portable/raspberrypi/rp2040/dcd_rp2040.c
2 participants
@dhalbert @hathach