Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbtmc: correct packet size bug #1783

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

scoudreau
Copy link
Contributor

Code was only reading the first 64 bytes of a 512 bytes packet.

For some reason, code was working if receiving a single packet strictly below 512 bytes. But when sending a USBTMC message which lead to a data stage longer than a single packet, only the first 64 bytes where read.
This seems to be only due to the "arming" of transfer which where obviously only asking for 64 bytes (constant).

scoudreau and others added 2 commits December 8, 2022 11:35
Code was only reading the first 64 bytes of a 512 bytes packet.
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, the main developer for usbtmc @pigrew only has FS device to test with. There is a recent update to get it running with HS #1531 , too bad, I keep "forgetting" to test it out. I will do a full revise later on.

@hathach hathach merged commit f4f85ba into hathach:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants