New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string descriptor fetch #1372

Merged

hathach merged 1 commit into hathach:master from tannewt:fix_string_desc

Mar 6, 2022

Collaborator

tannewt commented Mar 4, 2022

Setting the indices was commented out. Return false if the index is 0 because that indicates there is no string descriptor for it.


          Fix string descriptor fetch

f291243

tannewt requested a review from hathach

March 4, 2022 19:40

hathach approved these changes

View reviewed changes

Owner

hathach left a comment

Ah right, I forgot to revert the debug changes. Will do more test with new bare api example later

hathach merged commit f2c276d into hathach:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet