nrf5x: Request HFXO via OS #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
requested changes
Jan 17, 2022
Comment on lines
898
to
901
| #if CFG_TUSB_OS == OPT_OS_MYNEWT | ||
| usb_clock_request(); | ||
| return; | ||
| #endif |
There was a problem hiding this comment.
we should do #ifelse for the whole hfclk_enable() / hfclk_disable() to prevent gcc to emit unreachable statement warning
Mynewt (similar to Soft Device) has its own reference counting for HFXO oscillator. So far TinyUSB requested HFXO when VBUS was detected and stopped when VBUS was removed. But with Mynewt running HFXO can be stopped when other interested parties don't require HFXO anymore. This results in very difficult to track USB transmission errors. This change enables Mynewt specific HFXO management in Soft Device fashion.
kasjer
force-pushed
the
kasjer/nrf5x-request-clock-in-mynewt
branch
from
7ef67a1
to
f472512
Compare
hathach
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Mynewt (similar to Soft Device) has its own reference counting for
HFXO oscillator.
So far TinyUSB requested HFXO when VBUS was detected and stopped when
VBUS was removed.
But with Mynewt running HFXO can be stopped when other interested parties
don't require HFXO anymore. This results in very difficult to track
USB transmission errors when internal RC is used for USB clock source.
This change enables Mynewt specific HFXO management in Soft Device fashion.
Additional context
This PR should be merged AFTER matching mynewt PR is merged
apache/mynewt-core#2748