net_lwip_webserver: allow users to enable LWIP_IP6 if desired #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net_lwip_webserver and ./lib/networking/ code is tweaked to allow the user to enable LWIP_IP6 if desired.
To allow legacy code to compile, lwip's ip_addr_t maps into the newer ip4_addr_t type when LWIP_IP4 is enabled but LWIP_IP6 is not enabled. However, if both LWIP_IP4 and LWIP_IP6 are enabled, ip_addr_t maps to a struct with a union for both ip4_addr_t and ip6_addr_t. Since the ./lib/networking/ code was written for IPv4 only and presumes IP4-only lwip, the previous code breaks. Some tweaking was needed to use the newer ip4_addr_t in preference to the previous ip_addr_t usage.