Reorder switch #55
Merged
Reorder switch #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jovialiste82
requested review from
WhoaNellie,
jessdesr,
GuohaoOuyang,
dproc96 and
nalanart
dproc96
reviewed
Mar 25, 2021
|
I took care of most of the warnings. However I could not get rid of the key warning for Infinite Scroll. But after digging a bit on Google, it looks like it's a pending issue : oVirt/ovirt-web-ui#562 |
nalanart
reviewed
Mar 26, 2021
nalanart
reviewed
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm struggling with the styling so I am just creating a PR for the functionality just so it's implemented. I'll handle the styling in another branch/PR