add retry to webhook calls #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been tested? Also, is it possible to write a test for this? @0x777 ? |
|
currently the tests assume |
|
Hi ! |
|
This retry can be useful if the webhook was not able to accept the payload due to a temporary network glitch etc. Doing a blunt retry will make sure we don't lose calls due to this reason |
0x777
reviewed
May 20, 2018
| @@ -20,6 +21,8 @@ struct curl_fetch_st { | |||
| size_t size; | |||
| }; | |||
|
|
|||
| const int WEBHOOK_RETRY = 5; | |||
There was a problem hiding this comment.
Also should this be taken as an argument from command line?
There was a problem hiding this comment.
Why not waiting for client to send ack ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #7 talks about adding retries for webhook calls.