Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more OTEL configuration options #40

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Mar 14, 2024

  • Improve OTEL configuration options. The SDK no longer detects HTTP protocol via http(s) scheme in the URL. By default, the OTEL exporter uses GRPC protocol. You can change to HTTP protocol by using port 4318 or set OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf
  • Now you can choose only one metrics exporter by OTEL_METRICS_EXPORTER=<none|otlp|prometheus> variable. By default metrics exporter is disabled (none).
  • If OTEL_METRICS_EXPORTER != prometheus, the /metrics route returns HTTP 404. You can change Prometheus service to another port with OTEL_EXPORTER_PROMETHEUS_PORT variable.
  • Bad request HTTP status is changed to HTTP 422. Engine v3 only exposes errors with this status (source).

Copy link

github-actions bot commented Mar 14, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-sdk-go/cmd/ndc-go-sdk 74%
github.com/hasura/ndc-sdk-go/connector 55%
github.com/hasura/ndc-sdk-go/example/reference 63%
github.com/hasura/ndc-sdk-go/internal 46%
github.com/hasura/ndc-sdk-go/schema 39%
github.com/hasura/ndc-sdk-go/utils 43%
Summary 51% (3591 / 7052)

Minimum allowed line rate is 40%

@hgiasac hgiasac merged commit b79362f into v0 Mar 15, 2024
2 checks passed
@hgiasac hgiasac deleted the change-otlp-protocol-behavior branch March 15, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant