codegen: drop time.Duration support and update UUID scalar codegen #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
hgiasac
added a commit
that referenced
this pull request
Mar 7, 2024
hgiasac
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasura-ndc-goto follow the NDC CLI plugin specification. The codegen tool may be developed as a plugin in the future.time.Durationtype doesn't support JSON decoding from string, e.g.1s,1m. So the codegen tool shouldn't support that type. Users need to define a scalar wrapper to support it themselves.Decodertype that wrapsmapstructure.Encoderto support nested values mapping. Improve mapping fromanytypes without falling back to JSON encoding/decoding.uuid.UUIDdecoder is optionally generated if any argument or return type property contains this type.