make pg_table_metadata CockroachDB compatible #7788
Conversation
|
Beep boop! 🤖 Hey @otan, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
|
CockroachDB doesn't support `index` as a table alias, but PostgreSQL does. Since `idx` is supported by both, change the metadata query accordingly. Refs cockroachdb/cockroach#72407
|
✔️ Deploy Preview for hasura-docs ready! 🔨 Explore the source changes: f9d2033 🔍 Inspect the deploy log: https://app.netlify.com/sites/hasura-docs/deploys/61899ba915a29900071659fd 😎 Browse the preview: https://deploy-preview-7788--hasura-docs.netlify.app |
|
✔️ Deploy Preview for hasura-docs ready! 🔨 Explore the source changes: 84dbcec 🔍 Inspect the deploy log: https://app.netlify.com/sites/hasura-docs/deploys/61899c069d74450007f8fb47 😎 Browse the preview: https://deploy-preview-7788--hasura-docs.netlify.app |
|
This fell through the review cracks, I'm sorry! Thanks for the contribution, it looks good to me and we'll try to get it through today. |
|
Beep boop! 🤖 Awesome work @otan! Your changes were merged successfully. All of us at Hasura ❤️ what you did. Thanks again 🤗 |
GITHUB_PR_NUMBER: 7788 GITHUB_PR_URL: #7788 PR-URL: hasura/graphql-engine-mono#2805 Co-authored-by: Oliver Tan <[email protected]> GitOrigin-RevId: 9de4ddc
|
cheers! |
Description
CockroachDB doesn't support
indexas a table alias, but PostgreSQLdoes. Since
idxis supported by both, change the metadata queryaccordingly.
Changelog
No changelog required, but can't set a label.
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Refs cockroachdb/cockroach#72407
Solution and Design
See description.
Steps to test and verify
Existing tests should pass.