Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle unmatched types in permission builder #3712

Merged
merged 5 commits into from
Jan 17, 2020
Merged

handle unmatched types in permission builder #3712

merged 5 commits into from
Jan 17, 2020

Conversation

rikinsk
Copy link
Member

@rikinsk rikinsk commented Jan 15, 2020

Description

In permission builder, for columns with types not present in the mainitained list, a default set of operators will always get shown

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3603

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@rikinsk rikinsk requested a review from wawhal January 15, 2020 13:39
@rikinsk rikinsk added the c/console Related to console label Jan 15, 2020
@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 60ec65e

https://deploy-preview-3712--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 6db6fe7 deployed to Heroku: https://hge-ci-pull-3712.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3712-6db6fe76

@rikinsk rikinsk requested review from beerose and removed request for wawhal January 17, 2020 07:31
beerose
beerose reviewed Jan 17, 2020
View reviewed changes
console/src/components/Services/Data/TablePermissions/PermissionBuilder/utils.js Outdated
'dateTime',
'numeric',
'uuid',
'user_defined',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this list the same for every operator? Would it make sense to extract it to the variable, so that another changes would be done just in the one place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem like there can be a better way to represent this info. Will take a stab at it and request a review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beerose Made changes to avoid repetition in the future as well. This was a good catch. Thanks.

@hasura-bot
Copy link
Contributor

Review app for commit ad5f590 deployed to Heroku: https://hge-ci-pull-3712.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3712-ad5f590d

@rikinsk rikinsk requested a review from beerose January 17, 2020 08:44
@hasura-bot
Copy link
Contributor

Review app for commit 60ec65e deployed to Heroku: https://hge-ci-pull-3712.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3712-60ec65e8

@rikinsk rikinsk merged commit 9355436 into hasura:master Jan 17, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3712.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-permissions-unknown-types branch January 17, 2020 09:02
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
handle uncategorized types in permission builder (close hasura#3603) (h…
144ee35 
…asura#3712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beerose beerose beerose approved these changes

Assignees
No one assigned
Labels
c/console Related to console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikinsk @hasura-bot @beerose