Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add library files #1

Merged
merged 7 commits into from
Jun 13, 2019
Merged

Add library files #1

merged 7 commits into from
Jun 13, 2019
+465 −1

Conversation

ajeetdsouza
Copy link
Contributor

No description provided.

@shahidhk
Copy link
Member

@ajeetdsouza Can you run the Haskell files through stylish-haskell?

Just do stylish-haskell -i <file>

rakeshkky
rakeshkky reviewed Jun 13, 2019
View reviewed changes
src/CI.hs Outdated
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE TemplateHaskell #-}

module CI ( Types.CI(..), isCI, getCI ) where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exports in new line

module CI
    ( Types.CI (..)
    , ----
    , -----
    ) where

rakeshkky
rakeshkky reviewed Jun 13, 2019
View reviewed changes
src/CI.hs Outdated
import Data.Maybe ( isJust )
import qualified Data.Text as T

import System.Environment ( getEnvironment )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow import style mentioned here

rakeshkky
rakeshkky reviewed Jun 13, 2019
View reviewed changes
src/CI/Types.hs Outdated

instance Aeson.ToJSON VendorEnv where
toJSON val = case val of
VendorEnvString key -> Aeson.toJSON key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key -> name

rakeshkky
rakeshkky reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit ad6df73 into hasura:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakeshkky rakeshkky rakeshkky left review comments

@shahidhk shahidhk shahidhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajeetdsouza @shahidhk @rakeshkky