Set AWS_DEFAULT_ACL based on S3_DEFAULT_ACL config #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghaas
reviewed
Oct 2, 2024
| @@ -15,7 +15,7 @@ AWS_S3_ENDPOINT_URL = "{{ "https" if S3_USE_SSL else "http" }}://{{ S3_HOST }}{% | |||
|
|
|||
| AWS_S3_USE_SSL = {{ "True" if S3_USE_SSL else "False" }} | |||
| AWS_S3_SECURE_URLS = {{ "True" if S3_USE_SSL else "False" }} | |||
| AWS_DEFAULT_ACL = None # inherit from the bucket | |||
| AWS_DEFAULT_ACL = {{ '"{}"'.format(S3_DEFAULT_ACL) if S3_DEFAULT_ACL is defined else 'None' }} # None - inherit from the bucket | |||
There was a problem hiding this comment.
We tend to not use if x is defined constructs in our plugins. Instead, we define a default in plugin.py (even if that default is None).
There was a problem hiding this comment.
Cool. Looking forward merging #83
|
Closing as superseded by #83. Thanks for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set AWS_DEFAULT_ACL. Useful when you don't want to set bucket as public but still want handle profile images. By default the value remains the same -
None.