Studio Code Server doesn't work on access to HA by https with NGINX proxy #584
Comments
vdemidov
changed the title
|
After rollback to previous version 5.5.2 all works fine: |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@vdemidov , how did you did the rollback? Happening to me also. Thks!! |
|
There is no rollback, the only thing Home Assistant offers is restoring backups. ../Frenck |
|
@frenck , yep, thanks. Restored from backup and working! |
|
Please stop commenting +1 anywhere on GitHub, and just use an emoji reaction on the opening post instead. Those "same here" and +1 posts are highly polluting, annoying and absolutely add zero value to triaging an issue or the conversation around it. ../Frenck |
|
I think this update to code-server is causing the issue: This is confirmed when you do a browser network trace, the ws connection never comes back successfully. |
|
Also: Security The check requires the host header to be set so if you use a reverse proxy |
|
I was able to fix this by adding this to the Nginx Proxy Manager Custom Nginx Configuration: location / { # Proxy! |
|
In that case, |
Oh, I'm aware of that. I shouldn't say it's a fix as it's really a workaround. I just can't see where the differences are between my host and origin with the Nginx logging turned up to trace. I would love a better solution. |
|
Here's another workaround that doesn't strip the Origin header but instead makes sure to send the x-forwarded-host header location / { # Proxy! |
|
I had the same problem with my reverse proxy setup. Turns out to be misconfiguration on my side, where I had the following in Caddyfile: Effectively I was stripping a proxy info and pretending that I'm connected locally. I removed these two directives altogether (default Caddy reverse_proxy config handles it well) and instead fixed my What a noob mistake.. Thank you guys for the kick! 😊
|
Could you help with create issue for Home Assistant Add-on: NGINX Home Assistant SSL proxy? |
This comment was marked as outdated.
This comment was marked as outdated.
|
In my case, I have a separate Nginx server (not using the HA addon) - the proxy config looks the same as the HA addon one already. What do I need to set in the Nginx config files to mirror |
Oh actually I realized this is HA http config - I actually have |
If you watch to start message i have Nginx addon with default config and trusted_proxies in HA config. And have problems with VSCode. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I've created an issue for nginx-proxy-manager |
|
There is NO support for I fiddled with various things in the config and in the end gave up and reverted to 5.5.2. @frenck don't mean to sound like an arse but this should really go as a big warning in the release notes mate... Based on the above comments, I suspect changing the base config for the nginx addon here: And adding the I have no need for the For anyone else reading this and using the official nginx addon, save yourself a headache and do a partial restore on vscode to downgrade it. There is no easy fix until a new version of the nginx addon is released. |
For those who have a separate NGINX setup that is basically stock config, I was able to fix vscode loading by changing: to |
|
what about those with the HA nginx. How can we solve this? |
|
@charettepa all I can suggest is to make yourself heard here home-assistant/addons#2912 Or use the other nginx addon I guess |
|
I have confirmed the fix for stock nginx addon and opened a PR - if anyone wants steps to manually patch the nginx addon config until the addon is updated let me know. I'm not too sure if the patch persists through a restart though :) I'll have to find out ;) |
|
Closing this issue, as this is not an issue of this add-on. ../Frenck |
|
@charettepa
|
Problem/Motivation
After addon update to version 5.5.3 it doesn't work when HA accseed over https.
Expected behavior
Expected normally work with ingress by http and https
Actual behavior
Work only with direct access to HA by http.
When accessed by https with NGINX proxy error on screen after very long time and errros in log
Error text:
Steps to reproduce
Home Assistant Core: 2023.3.1
Home Assistant Supervisor: 2023.01.1
Home Assistant config:
Addon NGINX Home Assistant SSL proxy
Config:
Addon's log
Home Assistant Supervisor log:
23-03-06 10:42:05 ERROR (MainThread) [supervisor.api.ingress] Ingress error: 403, message='Invalid response status', url=URL('http://172.30.33.3:1337/stable-441438abd1ac652551dbe4d408dfcec8a499b8bf?reconnectionToken=ed7a7470-a38d-4b38-ac08-25ba3d197d48&reconnection=false&skipWebSocketFrames=false')The text was updated successfully, but these errors were encountered: