Add cloudflared #138
Merged
Add cloudflared #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
reviewed
Jan 6, 2024
uptime-kuma/Dockerfile
Outdated
Comment on lines
51
to
52
| RUN curl -L https://github.com/cloudflare/cloudflared/releases/latest/download/cloudflared-linux-amd64 -o /usr/bin/cloudflared \ | ||
| && chmod +x /usr/bin/cloudflared |
There was a problem hiding this comment.
Hi there @samuelleb11 👋
Two things:
- We don't have to create an additional Docker layer, just add it to the sequence above
- The
cloudflaredain't versioned. I rather have a version locked (so builds are reproducible, caches work properly, and we can ship updates if needed).
For the latter, please add an entry to the renovate configuration as well. We can pick up the latest information from: https://github.com/cloudflare/cloudflared/releases
|
I took the liberty to address the comments.
../Frenck |
frenck
approved these changes
Jan 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Issues