Make UDP port configurable #390
Conversation
WalkthroughThe recent update introduces a configuration option Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ConfigFile
participant TailscaleService
participant NetworkConfig
User->>ConfigFile: Adds udp_port to configuration
ConfigFile->>TailscaleService: Passes udp_port setting
TailscaleService->>NetworkConfig: Applies udp_port for WireGuard and peer-to-peer traffic
NetworkConfig->>TailscaleService: Confirms configuration
TailscaleService->>User: Service starts with specified udp_port
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- tailscale/DOCS.md (2 hunks)
- tailscale/config.yaml (1 hunks)
- tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (1 hunks)
- tailscale/translations/en.yaml (1 hunks)
Additional comments not posted (5)
tailscale/config.yaml (1)
45-45: Addition ofudp_portfield looks good.The
udp_portfield has been added correctly to the schema section, following the existing pattern and structure.tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (1)
19-23: Logic to use configured UDP port looks good.The script correctly checks for the
udp_portconfiguration and adds it to the options if specified.tailscale/translations/en.yaml (1)
93-97: Addition ofudp_porttranslation strings looks good.The translation strings for the
udp_portconfiguration option have been added correctly, following the existing pattern and structure.tailscale/DOCS.md (2)
83-83: Addition ofudp_portoption in the configuration example looks good.The
udp_portoption has been added correctly to the configuration example, following the existing format.
315-324: Documentation forudp_portoption looks good.The documentation provides a clear explanation of the
udp_portoption and its usage, following the existing format.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- tailscale/DOCS.md (1 hunks)
- tailscale/config.yaml (1 hunks)
- tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (2 hunks)
- tailscale/translations/en.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- tailscale/DOCS.md
- tailscale/config.yaml
- tailscale/translations/en.yaml
Additional comments not posted (3)
tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (3)
8-8: LGTM! Variable declaration is correct.The declaration of the
udp_portvariable is straightforward and follows the existing pattern.
20-24: LGTM! Logic to retrieve and use the configured UDP port is correct.The logic to retrieve the UDP port from the addon configuration and add it to the options array is clear and correctly implemented.
Line range hint
8-24:
LGTM! Changes are well-integrated.The changes are seamlessly integrated within the existing script structure, maintaining readability and functionality.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Not stale, waiting for decision whether it should be a plain config option or a network port. |
github-actions
bot
removed
the
stale
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- tailscale/DOCS.md (1 hunks)
- tailscale/config.yaml (1 hunks)
- tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (2 hunks)
- tailscale/translations/en.yaml (1 hunks)
Additional comments not posted (4)
tailscale/config.yaml (1)
28-29: LGTM! Port configuration added successfully.The addition of the
portsentry for UDP traffic on port 41641 aligns with the PR objectives and enhances the configuration.tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (1)
Line range hint
8-24: LGTM! UDP port configuration logic added successfully.The addition of the
udp_portvariable and the logic to configure Tailscale's options with a user-defined UDP port enhances the flexibility of the startup script.tailscale/translations/en.yaml (1)
101-104: LGTM! New network configuration option added.The addition of the UDP port configuration under the
networksection provides users with more control over their network setup.tailscale/DOCS.md (1)
336-347: Documentation update looks good!The new section provides clear and concise information about the UDP port configuration, aligning with the PR objectives and linked issues.
Proposed Changes
Without this option TS is not always able to establish peer-to-peer connections.
See #388 for more details.
Related Issues
fixes #388 #372
Summary by CodeRabbit
New Features
udp_portoption to specify the UDP port for WireGuard and peer-to-peer traffic.41641.Documentation
41641for enhancing peer-to-peer connectivity, especially in CGNAT scenarios.tailscale ping <hostname-or-ip>command.