Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logo/icon to current version. #216

Merged
merged 4 commits into from
Feb 4, 2024
Merged

Update logo/icon to current version. #216

merged 4 commits into from
Feb 4, 2024

Conversation

danielpetrovic
Copy link
Contributor

Proposed Changes

Update logo/icon to current version.

@frenck frenck added the maintenance Generic maintenance tasks. label Jan 28, 2024
frenck
frenck requested changes Jan 28, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things:

  • Can you make sure the icon is filled out as much as possible?
  • The logo isn't the logo they are currently carrying? See:

CleanShot 2024-01-28 at 20 41 09@2x

@danielpetrovic
Copy link
Contributor Author

Got the Logo directly from PLEX now, this is the current one.
The Icon.png is the same as the one used in the PLEX apps, does it need to be squared without the rounded corners?

frenck
frenck approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danielpetrovic 👍

../Frenck

@frenck frenck merged commit d375ed0 into hassio-addons:main Feb 4, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
maintenance Generic maintenance tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielpetrovic @frenck