Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for automatically reloading the list files of dnsbl-lookup #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sander-Kastelein
Copy link

I'd like this feature very much for my current project, I only require dnsbl-lookup once and the sysadmin would like to edit the JSON files without having to reboot the whole node process.

@hassansin
Copy link
Owner

That's a good point but watching files will also push callbacks in event loop and prevent nodejs from exiting normally. I think you should maintain a separate files for list instead of editing the default list files. Then call the lookup methods with the list argument each time those files have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants