Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTF-8 Encoded Text #1
UTF-8 Encoded Text #1
Changes from 1 commit
f8ee7e3
c184a9e
666518d
cd12a3a
7b79d75
5bea03d
3579759
c015ff2
dccba12
bd0828f
737ca00
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither
Cabal
norcabal-install
useText
at the moment. It does use (vendored version) ofShortText
though.IMO you can just drop
Cabal
from the list, it won't be affected unless there is some need to useText
inCabal
(which there isn't as far as I can tell).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about Cabal internals, but
Cabal.cabal
seems to includetext
:https://github.com/haskell/cabal/blob/4f8aeb2c8a0a3638e1af887dc869a17e291c8329/Cabal/Cabal.cabal#L272
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defines few instances for
Text
, it's not really used.If any change in
text
affectsCabal
performance, that will be interesting.TL;DR
text
dependency could be dropped quite easily, but there is really no point as it's there viaparsec
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking of
Cabal
made me rememberpandoc
. It can be called the Haskell app, and it usesText
extensively. So if you want to have some real project on the list, i'd nominate it.The promise that API doesn't change too much should make building
pandoc
even with its dependency footprint only a matter of CPU time.Addition:
pandoc
is also as text processing tool as a tool (written in Haskell) can be, so if it clearly benefits, that could be enough to declare the success of the whole proposal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, interesting, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilypi shall we remove Cabal from stakeholders?