Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding a GADT constructor in let doesn't work #548

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

tomsmeding
Copy link
Contributor

@tomsmeding tomsmeding commented Oct 30, 2024

People sometimes run into this (e.g. here), and the fix is quite non-obvious from the error message. I thought it might be good to expand the pages for the relevant error messages with a relevant example; the existing ones are for very different situations.

I found it very amusing that I needed to edit the pages for two error messages, because the generated error depends on whether -XTypeFamilies is active.

The text here is kind of stub; I didn't have time to write an in-depth description. Feel free to improve. But hopefully this is already useful.

Copy link
Collaborator

@BinderDavid BinderDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Thanks!

@BinderDavid BinderDavid merged commit ef9b718 into haskellfoundation:main Nov 2, 2024
2 checks passed
@tomsmeding tomsmeding deleted the gadt-by-let branch November 2, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants