Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use haskeline in create script #513

Merged
merged 7 commits into from
Jun 8, 2024
Merged

Conversation

BinderDavid
Copy link
Collaborator

@BinderDavid BinderDavid commented Jun 8, 2024

Fixes #499

Uses haskeline to allow easier line-editing when using the create-message-template.hs script.

@BinderDavid
Copy link
Collaborator Author

@noughtmare Can you take a look and verify that it works as intended?

@BinderDavid BinderDavid marked this pull request as ready for review June 8, 2024 10:04
@BinderDavid BinderDavid requested a review from jhrcek June 8, 2024 10:05
@noughtmare
Copy link

It might be good to add constraints to the dependencies (at least lower bounds).

Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍 . Just a small suggestion for one prompt that confused me yesterday.

message-index/create-message-template.hs Outdated Show resolved Hide resolved
@BinderDavid BinderDavid merged commit f7c49e5 into main Jun 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use haskeline for create-message-template.hs
3 participants