Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #444 (hakyll runs out of file handles) #455

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Fix issue #444 (hakyll runs out of file handles) #455

merged 6 commits into from
Aug 28, 2023

Conversation

BinderDavid
Copy link
Collaborator

Fixes #444
On systems which don't provide enough file handles to processes, building the site with hakyll can fail since hakyll holds on to too many file handles at the same time.
This commit bumps the minimum requirement on hakyll to version 4.16.1.0, which fixes the problem.

I am just running this through CI for the moment, to see if it also works there.

On systems which don't provide enough file handles to processes,
building the site with hakyll can fail since hakyll holds on
to too many file handles at the same time.
This commit bumps the minimum requirement on hakyll to version 4.16.1.0,
which fixes the problem.
@BinderDavid
Copy link
Collaborator Author

Since this hakyll version is just 1 day old on Hackage, people will have to run cabal update in order to be able to build. The error message one gets otherwise is known to not be ideal in that case: haskell/cabal#8922

@BinderDavid
Copy link
Collaborator Author

@david-christiansen
You wrote in the issue:

I suppose we should experiment a bit with bounds to make sure this release works with everything that we want to support, then close this up.

Did you have anything specific in mind which maybe would not work? I also made sure that the site can be built using stack buildagain, so I think we could just bump the lower bound for hakyll in the cabal file. The only issue I can foresee is that people have to update their cabal index with cabal update before they can build the site again, cabal is unfortunately not very helpful in that case.

@david-christiansen
Copy link
Contributor

The only thing I had in mind would be if the new Hakyll required a newer base or some other library, but a quick skim of the dependencies doesn't reveal any obvious issues.

@BinderDavid BinderDavid merged commit 842f4e1 into main Aug 28, 2023
@BinderDavid BinderDavid deleted the fix-444 branch September 27, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build problems on Mac due to max number of file handles
2 participants