Use zlib-clib on Windows, unless pkg-config is available #70
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
approved these changes
Apr 21, 2024
zlib/zlib.cabal
Outdated
| -- | ||
| -- On Windows zlib is shipped with GHC starting from 7.10 | ||
| -- at mingw/lib/libz.a. Yet linking against it proves unreliable: | ||
| -- while GHC always links against mingw/lib whatever the PATH, |
There was a problem hiding this comment.
This is a bit misleading, since GHC won't consult your PATH at link time, only at runtime. It might be better to phrase this as:
On Windows, zlib is shipped as part of GHC's mingw/lib directory, which GHC always includes in its linker search path. However, there is no guarantee that zlib1.dll (the corresponding shared library) will be available on the user's PATH at runtime, making it risky to depend upon (see #65 for what can go wrong). Thus, we resort to zlib-clib unless pkg-config is available.
Or something like that.
There was a problem hiding this comment.
Thanks! I'll use the suggested wording.
Bodigrim
force-pushed
the
bundle-zlib-clib-on-windows
branch
from
6ce8114 to
a7b7d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65.