Remove hoogle command from vscode extension #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed, remove this custom command since we are the HLS plugin. If such a feature is desired, https://github.com/haskell-spotlight/haskell-spotlight is probably a better fit. |
The command allows to import an identifier via hoogle. Such a feature should be contributed by HLS, not the vscode-plugin. If searching on hoogle is desired, prefer haskell-spotlight.
fendor
force-pushed
the
remove/custom-commands
branch
from
2e833db to
dc06858
Compare
michaelpj
approved these changes
Jun 30, 2023
hasufell
approved these changes
Jul 1, 2023
This was referenced Jul 1, 2023
Merged
|
I finally found this feature after it has been removed😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command allows to import an identifier via hoogle. Such a feature should be contributed by HLS, not the vscode-plugin.
If searching on hoogle is desired, prefer haskell-spotlight.