Ignore missing entries in Release Metadata #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
fix/missing-release-metadata-entries
branch
from
74cc97b to
12741af
Compare
fendor
commented
Apr 17, 2022
src/hlsBinaries.ts
Outdated
Comment on lines
789
to
798
| metadata.forEach((supportedArch, hlsVersion) => { | ||
| const supportedOs = supportedArch.get(arch); | ||
| if (supportedOs) { | ||
| const ghcSupportedOnOs = supportedOs.get(platform); | ||
| if (ghcSupportedOnOs) { | ||
| logger.log(`HLS ${hlsVersion} compatible with GHC Versions: ${ghcSupportedOnOs}`); | ||
| newMap.set(hlsVersion, ghcSupportedOnOs); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the only tangible change. Everything else should be only logging statements.
Add various logging statements. Demote excessive logging to debug level. Refactor hard to read functions. Add more typing information.
fendor
force-pushed
the
fix/missing-release-metadata-entries
branch
from
12741af to
fb90aa5
Compare
hasufell
reviewed
Apr 18, 2022
| window.showErrorMessage(e.message); | ||
| } else if (e instanceof Error) { | ||
| logger.error(`Internal Error: ${e.message}`); | ||
| window.showErrorMessage(e.message); | ||
| } | ||
| if (e instanceof Error) { |
There was a problem hiding this comment.
Why do we log twice for Error?
There was a problem hiding this comment.
This is a "catch-all" for errors and always prints the stack trace of the caught exception.
hasufell
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add various logging statements.
Demote excessive logging to debug level.
Refactor hard to read functions.
Add more typing information.