Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iso-deriving for Unboxed instances #378

Merged
merged 6 commits into from
May 26, 2021
Merged

Add iso-deriving for Unboxed instances #378

merged 6 commits into from
May 26, 2021

Commits on May 24, 2021

  1. Add iso-deriving for Unboxed instances 

    This should largely subsume TH-based deriving from th-vector-unbox. Verbosity is
about same and there's no TH which is frequently breaks with each GHC release
    @Shimuuar
    Shimuuar committed May 24, 2021
    Configuration menu
    Copy the full SHA
    faa8d45 View commit details
    Browse the repository at this point in the history

  2. Rename Isomorphic -> IsoUnbox

    @Shimuuar
    Shimuuar committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5b49ad3 View commit details
    Browse the repository at this point in the history

  3. Add generic-based default instance for IsoUnbox 

    It works by coercing between Generic representations of data types.
    @Shimuuar
    Shimuuar committed May 24, 2021
    Configuration menu
    Copy the full SHA
    cf583e6 View commit details
    Browse the repository at this point in the history

  4. We need to export V_UnboxAs in order to be able to use DerivingVia

    @Shimuuar
    Shimuuar committed May 24, 2021
    Configuration menu
    Copy the full SHA
    4ffe410 View commit details
    Browse the repository at this point in the history

  5. Use correct prefixes in doctests so they could be copy-pasted 

    Before we used prefixes that in scope in given module
    @Shimuuar
    Shimuuar committed May 24, 2021
    Configuration menu
    Copy the full SHA
    03dcb98 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Add tests to check that iso-deriving works 

    Namely that optimizer is able to fully eliminate generics
    @Shimuuar
    Shimuuar committed May 25, 2021
    Configuration menu
    Copy the full SHA
    fae2e17 View commit details
    Browse the repository at this point in the history