Fix issues with vector slice function #279
Conversation
* Streaming causing bounds to not be checked, thus not failing slicing. Which differed from the semantics of `slice` when compiled with -O0 * Out of memory explosion when size supplied to `slice` is too high
|
wonderful! of course we need to fix that fusion rule, but this is better than not. (i think we could maybe change the rules around to push around the interval information into the fused code, but thats not what we 're here for today) |
|
To be honest I am pretty sure it is NOT possible fixing that fusion rule without changing semantics of |
|
it is possible or impossible? i'm confused :) |
|
Sorry, not possible 🤦♂️ |
|
i'm going to say "yes, impossible if we dont change the rules/fusion stuff", but i THINK if we add some hooks for "evidence" passing that we can later erase, there might be a way :) |
|
this may be slightly beyond what GHC can currently do, and that might motivate some fun slow motion compiler hacking |
|
I've been wrong before ;) There might be a trick that I am simply not aware of. |
Fixes #257