Add new Data instances for immutable vectors #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Apr 4, 2018
There was a problem hiding this comment.
Thanks @andy-morris, this looks good to me. One minor comment inline.
Data/Vector/Generic.hs
Outdated
| mkType :: String -> DataType | ||
| {-# INLINE mkType #-} | ||
| mkType = mkNoRepType | ||
| mkTypeConstr :: String -> (DataType, Constr) |
There was a problem hiding this comment.
Tupling these together feels a mite strange. Why not separate these into two separate functions which return DataType and Constr respectively? Then you wouldn't have to manually project out of it with fst and snd everywhere.
There was a problem hiding this comment.
I only tupled them because they're mutually recursive, but I know that's a bit of a silly reason. I'll separate them this evening when I get a chance.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included a test for
gfoldl, but not forgunfoldbecause I don't really know how to use it. If someone has any pointers, I'll be happy to add one for it too.