Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure next major version bump includes the correct role annotations for each vector type #277

Closed
cartazio opened this issue Jan 30, 2020 · 2 comments · Fixed by #316
Closed

Make sure next major version bump includes the correct role annotations for each vector type #277

cartazio opened this issue Jan 30, 2020 · 2 comments · Fixed by #316
Milestone
0.13

Comments

@cartazio
Copy link
Contributor

cartazio commented Jan 30, 2020 •
edited
Loading

Storable Vectors need a nominal role, and thats likely true for everything but boxed vectors! (afaict)
@Shimuuar
Copy link
Contributor

Shimuuar commented Jun 10, 2020 •
edited
Loading

Current state of vector data types:

  • Data.Vector: inferred representational
  • Data.Vector.Storable: annotated nominal
  • Data.Vector.Primitive: annotated representational
  • Data.Vector.Unboxed: inferred nominal

I think that Primitive should get same nominal annotation as Storable for same reasons.

@cartazio
Copy link
Contributor Author

cartazio commented Jun 10, 2020 via email

@Shimuuar Shimuuar modified the milestones: 0.12.2, 0.13 Jun 11, 2020
Shimuuar added a commit to Shimuuar/vector that referenced this issue Jun 13, 2020
@Shimuuar
Make primitive vectors nominally roled
3874631 
Reasoning is identical to one for storable vectors. See discussion in haskell#224, and
PR haskell#235.

Fixes haskell#277
@Shimuuar Shimuuar mentioned this issue Jun 13, 2020
Merged
Shimuuar added a commit to Shimuuar/vector that referenced this issue Jun 14, 2020
@Shimuuar
Make primitive vectors nominally roled
1fdfea1 
Reasoning is identical to one for storable vectors. See discussion in haskell#224, and
PR haskell#235.

Fixes haskell#277
Shimuuar added a commit to Shimuuar/vector that referenced this issue Jun 14, 2020
@Shimuuar
Make primitive vectors nominally roled
b35a6d3 
Reasoning is identical to one for storable vectors. See discussion in haskell#224, and
PR haskell#235.

Fixes haskell#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Make primitive vectors nominally roled Shimuuar/vector
2 participants
@cartazio @Shimuuar