Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fromString INLINEABLE #571

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Make fromString INLINEABLE #571

merged 1 commit into from
Mar 13, 2024

Conversation

Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Mar 13, 2024

Closes #549

The generated Core for f = "a cat" <> "a dog" <> "a fish" :: Data.Text.Lazy.Builder is now more reasonable:

f = "a cat"#

f1 = unpackCString# f

f2 = "a dog"#

f3 = unpackCString# f2

f4 = "a fish"#

f5 = unpackCString# f4

$wf
  = \ @s x ww ww1 ww2 ww3 eta ->
      let {
        lvl
          = \ ds eta1 ->
              case ds of { Buffer ww4 ww5 ww6 ww7 ->
              $wfromString f5 x ww4 ww5 ww6 ww7 eta1
              } } in
      $wfromString
        f1
        ((\ eta1 eta2 ->
            case eta1 of { Buffer ww4 ww5 ww6 ww7 ->
            $wfromString f3 (lvl `cast` <Co:9> :: ...) ww4 ww5 ww6 ww7 eta2
            })
         `cast` <Co:9> :: ...)
        ww
        ww1
        ww2
        ww3
        eta

@Bodigrim Bodigrim merged commit a011d4a into master Mar 13, 2024
47 of 51 checks passed
@Bodigrim Bodigrim deleted the inlineable-fromString branch March 13, 2024 19:47
@Bodigrim
Copy link
Contributor

Thanks!

@Bodigrim
Copy link
Contributor

@hasufell @angerman any idea what's up with ARM runners? They used to work couple of weeks ago.

@hasufell
Copy link
Member

Those are @angerman's runnners. Mine should still work. You can force my runner via runs-on: [self-hosted, Linux, ARM64, maerwald].

@angerman
Copy link
Contributor

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, ... . For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

My runners don't have node-16 anymore.

@hasufell
Copy link
Member

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, ... . For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

My runners don't have node-16 anymore.

Seems you've turned a warning into an error.

We will actively monitor the migration's progress and gather community feedback before finalizing the transition date.

@Bodigrim
Copy link
Contributor

Thanks, @angerman, we upgraded to Node.js 20, looks working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromString from Data.Text.Lazy.Builder generates massive amount of code
4 participants