-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with cherokee characters & toCaseFold #277
Labels
question
Requires more investigation
Comments
Ok, so this is due to the rules from specifically foldMapping '\xab99' s = Yield '\x13c9' (CC s '\x0000' '\x0000') and foldMapping c s = Yield (toLower c) (CC s '\0' '\0') |
Also hit it in https://bugs.gentoo.org/736388 |
phadej
added a commit
to phadej/text
that referenced
this issue
Aug 25, 2020
- Add property and regression test that toCaseFold should be idempotent - Add scripts/tests.sh to run tests with all GHCs. There are plenty of setup commands to pass. - Rework CaseFolding.hs so it considers that toLower behaves differently with different GHCs, and therefore fallbacks to it only when it behaves consistently. For that purpose a helper `scripts/Dump.hs` is added. Note: `toLower`, `toUpper`, and `toTitle` would benefit from using dumped database as well. This commit is already quite big, so that is left for a follow up.
phadej
added a commit
to phadej/text
that referenced
this issue
Aug 25, 2020
- Add property and regression test that toCaseFold should be idempotent - Add scripts/tests.sh to run tests with all GHCs. There are plenty of setup commands to pass. - Rework CaseFolding.hs so it considers that toLower behaves differently with different GHCs, and therefore fallbacks to it only when it behaves consistently. For that purpose a helper `scripts/Dump.hs` is added. Also MurMurVariant is quick hash which works with all GHCs, it should notice if there are changes in the behaviour. Note: `toLower`, `toUpper`, and `toTitle` would benefit from using dumped database as well. This commit is already quite big, so that is left for a follow up.
@phadej I see that three commits reference this issue - is this still open? |
Yes, #293 |
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 7, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 9, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 9, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 12, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 12, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 12, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
added a commit
to ezzieyguywuf/gentoo-haskell
that referenced
this issue
Jan 13, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]>
trofi
pushed a commit
to gentoo-haskell/gentoo-haskell
that referenced
this issue
Jan 14, 2021
test was previously restricted in 1.0.0.1 due to an upstream issue in ghc/text[1]. While the issue remains open, I have succesufully compiled the test suite for binary-instances-1.0.1, and it seems to pass all tests. [1]: haskell/text#277 Signed-off-by: Wolfgang E. Sanyer <[email protected]> Signed-off-by: Sergei Trofimovich <[email protected]>
This issue still happens with text-2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ref haskellari/binary-instances#7:
The text was updated successfully, but these errors were encountered: