Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look in ncurses/ for ncurses headers #21

Closed
wants to merge 1 commit into from

Conversation

bgamari
Copy link
Collaborator

@bgamari bgamari commented Apr 20, 2017

DragonflyBSD installs ncurses.h as /usr/local/include/ncurses.h.
Moreover, ncurses.h refers to ncurses/ncurses_dll.h. Consequently, it is
necessary to compile with --with-curses-includes=/usr/local/include and
teach configure to look for ncurses.h in ncurses/

This appears to be what the AX_WITH_CURSES recipe does (https://www.gnu.org/software/autoconf-archive/ax_with_curses.html).

DragonflyBSD installs ncurses.h in /usr/local/include/ncurses.h.
Moreover, ncurses.h refers to ncurses/ncurses_dll.h. Consequently, it is
necessary to compile with --with-curses-includes=/usr/local/include and
teach configure to look for ncurses.h in ncurses/
judah added a commit that referenced this pull request Apr 21, 2017
It's complicated (see e.g. PR #21), and we don't actually need it for the
build.
@judah
Copy link
Collaborator

judah commented Apr 21, 2017

After taking another look at that code, I realized we don't actually use (n)curses.h anywhere when building this package. I've created #22 to remove this logic altogether; let me know how that looks to you.

@bgamari
Copy link
Collaborator Author

bgamari commented Apr 21, 2017

Note that we will still need to adjust the path to term.h as appropriate.

@bgamari
Copy link
Collaborator Author

bgamari commented Apr 21, 2017

Ahh, never mind. I see now that you remove all the include logic.

@judah
Copy link
Collaborator

judah commented Apr 21, 2017

Closing in favor of #22.

@judah judah closed this Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants