Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compiling for wasm32-wasi #240

Closed
wants to merge 1 commit into from

Conversation

TerrorJack
Copy link
Contributor

This patch postpones compile-time errors to run-time, and allow Haskell projects that link to process but doesn't actually spawn child processes to build on wasm32-wasi successfully.

@snoyberg
Copy link
Collaborator

I don't see an issue with this. Any thoughts @bgamari?

@snoyberg
Copy link
Collaborator

This seems to have broken CI with:

Package check reported the following errors:
Unknown architecture name 'wasm32'

@TerrorJack
Copy link
Contributor Author

Yes, this is blocked on haskell/cabal#8096 for the time being; if you wouldn't mind, let's leave this PR open for some more time, until Cabal tags a release with the fix, then it'll be possible to get CI green again on this PR.

@TerrorJack
Copy link
Contributor Author

@snoyberg I've changed this PR to avoid relying on arch(wasm32) Cabal conditional, so CI should be green, would you initiate another CI run and take a look?

Copy link
Collaborator

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's certainly better that it doesn't break CI, but I'm still concerned about including code like this in a base library. @bgamari do you have any thoughts from the GHC side?

@TerrorJack
Copy link
Contributor Author

Closing in favor of #270.

@TerrorJack TerrorJack closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants