Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #506 #507

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix #506 #507

merged 1 commit into from
Jul 8, 2021

Conversation

complyue
Copy link
Contributor

@complyue complyue commented Jul 7, 2021

I'm not sure what 500 implies, but this is how
joyent/libuv@7233796
fixed
joyent/libuv#1195

@complyue complyue mentioned this pull request Jul 7, 2021
Closed
@kazu-yamamoto kazu-yamamoto self-requested a review July 8, 2021 00:25
kazu-yamamoto
kazu-yamamoto approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a SmartOS environment but I trust you.

@kazu-yamamoto kazu-yamamoto merged commit c6bf9c9 into haskell:master Jul 8, 2021
@kazu-yamamoto
Copy link
Collaborator

Merged. Thank you for your contribution!

@complyue complyue deleted the fix506 branch July 8, 2021 10:20
@complyue
Copy link
Contributor Author

complyue commented Jul 8, 2021

@kazu-yamamoto Thanks for your trust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@complyue @kazu-yamamoto