Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export StructLinger #491

Closed
wants to merge 2 commits into from
Closed

Export StructLinger #491

wants to merge 2 commits into from

Conversation

coot
Copy link
Contributor

@coot coot commented Nov 17, 2020

StructLinger is useful to set linger option on, with 0 interval using
setSockOpt. This is useful to make 'close' set the RST flag on FIN
packet (reset the connection). This is not possible with a higher level
setSocketOption.

This patch also adds record fields to the StructLinger record and
adds haddoc documentation.

coot added 2 commits November 17, 2020 19:31
StructLinger is useful to set linger option on, with 0 interval using
`setSockOpt`.  This is useful to make 'close' set the RST flag on FIN
packet (reset the connection).  This is not possible with a higher level
`setSocketOption`.

This patch also adds record fields to the `StructLinger` record and
adds haddoc documentation.
@kazu-yamamoto kazu-yamamoto self-requested a review January 13, 2021 00:40
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request Jan 13, 2021
@kazu-yamamoto
Copy link
Collaborator

Merged. Thank you for your contribution!

coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Feb 3, 2021
We can remove it once new version of network library is released;
haskell/network#491 is merged by now.
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Feb 4, 2021
We can remove it once new version of network library is released;
haskell/network#491 is merged by now.
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Feb 9, 2021
We can remove it once new version of network library is released;
haskell/network#491 is merged by now.
@coot coot deleted the export-StructLinger branch August 28, 2022 12:01
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
iohk-bors bot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 30, 2022
3979: Socket configuration r=coot a=coot

# Description

Fixes #3977
         
- Updated network dependency (haskell/network#491 was merged)  
- snocket: various stylistic changes       
- snocket: do not configure sockets in bind method 
- connection-manager: add a method to configure connection sockets 
- socket: added methods to configure sockets 
- Increment zfs copy fail counter
     



Co-authored-by: Marcin Szamotulski <[email protected]>
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 30, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
iohk-bors bot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Aug 31, 2022
3979: Socket configuration r=coot a=coot

# Description

Fixes #3977
         
- Updated network dependency (haskell/network#491 was merged)  
- snocket: various stylistic changes       
- snocket: do not configure sockets in bind method 
- connection-manager: add a method to configure connection sockets 
- socket: added methods to configure sockets 
- Increment zfs copy fail counter
     



Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Sep 1, 2022
3979: Socket configuration r=coot a=coot

# Description

Fixes #3977
         
- Updated network dependency (haskell/network#491 was merged)  
- snocket: various stylistic changes       
- snocket: do not configure sockets in bind method 
- connection-manager: add a method to configure connection sockets 
- socket: added methods to configure sockets 
- Increment zfs copy fail counter
     



Co-authored-by: Marcin Szamotulski <[email protected]>
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Oct 27, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Oct 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
coot added a commit to IntersectMBO/ouroboros-network that referenced this pull request Oct 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see
haskell/network#491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants