-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export StructLinger #491
Closed
Closed
Export StructLinger #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StructLinger is useful to set linger option on, with 0 interval using `setSockOpt`. This is useful to make 'close' set the RST flag on FIN packet (reset the connection). This is not possible with a higher level `setSocketOption`. This patch also adds record fields to the `StructLinger` record and adds haddoc documentation.
Only Eq, Ord and Show.
kazu-yamamoto
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 13, 2021
Merged. Thank you for your contribution! |
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Feb 3, 2021
We can remove it once new version of network library is released; haskell/network#491 is merged by now.
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Feb 4, 2021
We can remove it once new version of network library is released; haskell/network#491 is merged by now.
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Feb 9, 2021
We can remove it once new version of network library is released; haskell/network#491 is merged by now.
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
9 tasks
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 29, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 30, 2022
3979: Socket configuration r=coot a=coot # Description Fixes #3977 - Updated network dependency (haskell/network#491 was merged) - snocket: various stylistic changes - snocket: do not configure sockets in bind method - connection-manager: add a method to configure connection sockets - socket: added methods to configure sockets - Increment zfs copy fail counter Co-authored-by: Marcin Szamotulski <[email protected]>
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 30, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Aug 31, 2022
3979: Socket configuration r=coot a=coot # Description Fixes #3977 - Updated network dependency (haskell/network#491 was merged) - snocket: various stylistic changes - snocket: do not configure sockets in bind method - connection-manager: add a method to configure connection sockets - socket: added methods to configure sockets - Increment zfs copy fail counter Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Sep 1, 2022
3979: Socket configuration r=coot a=coot # Description Fixes #3977 - Updated network dependency (haskell/network#491 was merged) - snocket: various stylistic changes - snocket: do not configure sockets in bind method - connection-manager: add a method to configure connection sockets - socket: added methods to configure sockets - Increment zfs copy fail counter Co-authored-by: Marcin Szamotulski <[email protected]>
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 27, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
coot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Oct 28, 2022
network-3.1.2.2 package exposes `StructLinger`, see haskell/network#491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructLinger is useful to set linger option on, with 0 interval using
setSockOpt
. This is useful to make 'close' set the RST flag on FINpacket (reset the connection). This is not possible with a higher level
setSocketOption
.This patch also adds record fields to the
StructLinger
record andadds haddoc documentation.