Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing undefined as many as possible. #456

Merged
merged 1 commit into from
May 19, 2020
Merged

removing undefined as many as possible. #456

merged 1 commit into from
May 19, 2020

Conversation

kazu-yamamoto
Copy link
Collaborator

This is step 1) discussed in #454
Cc: @vdukhovni

@kazu-yamamoto kazu-yamamoto requested a review from eborden May 19, 2020 00:31
vdukhovni
vdukhovni approved these changes May 19, 2020
View reviewed changes
Copy link

@vdukhovni vdukhovni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit d565d9e into haskell:master May 19, 2020
@kazu-yamamoto kazu-yamamoto deleted the rm-undefined branch May 19, 2020 01:42
@kazu-yamamoto
Copy link
Collaborator Author

Merged. Thank you for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdukhovni vdukhovni vdukhovni approved these changes

@eborden eborden Awaiting requested review from eborden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazu-yamamoto @vdukhovni