Add regression test for socket connect function #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eborden
force-pushed
the
eborden/add-test-for-connect
branch
from
ff369ac to
1c739a7
Compare
A recent regression occurred where errors were not being thrown from `connect`. This is easily avoidable with two simple tests to check success and error.
eborden
force-pushed
the
eborden/add-test-for-connect
branch
from
a0b6c08 to
5944f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent regression occurred where errors were not being thrown from
connect. This is easily avoidable with two simple tests to checksuccess and error.
Related to: #368