Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network 2.7 no buildinfo callconv #323

Closed

Conversation

Mistuke
Copy link
Collaborator

@Mistuke Mistuke commented May 28, 2018

This updated the 2.7 branch to remove the need to specify callconv inside buildinfo just like the master branch.

This works around a stack issue where the incorrect sed is used.

Fixes #313

@kazu-yamamoto kazu-yamamoto mentioned this pull request May 29, 2018
5 tasks
@kazu-yamamoto
Copy link
Collaborator

I've rebased this onto the top of 2.7 and pushed to my repo.
I'm waiting for the result of CI now.

@kazu-yamamoto
Copy link
Collaborator

s/HsDef.h/HsNetDef.h/ in network.cabal is necessary. I will take care of this myself.

Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed
LGTM.
I will merge this.

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request May 29, 2018
@kazu-yamamoto
Copy link
Collaborator

Merged. Thank you for your effort!

@Mistuke
Copy link
Collaborator Author

Mistuke commented May 29, 2018

Thanks @kazu-yamamoto !

@Mistuke Mistuke deleted the update-network-2.7-no-buildinfo-callconv branch May 29, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants