Refactoring after #216 changes #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did the following two things:
So, I have merged this. This patch makes source and test code much more beautiful. Thank you for your contribution! |
Closed
eborden
added a commit
that referenced
this pull request
May 17, 2017
* Zero memory of `sockaddr_un` if abstract socket [#220](#220) * Improving error messages [#232](#232) * Allow non-blocking file descriptors via `setNonBlockIfNeeded` [#242](#242) * Update config.{guess,sub} to latest version [#244](#244) * Rename `my_inet_ntoa` to avoid symbol conflicts [#228](#228) * Test infrastructure improvements [#219](#219) [#217](#217) [#218](#218) * House keeping and cleanup [#238](#238) [#237](#237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a decent chunk of code.
About the test changes: I added a test for the behavior with
ByteStringand one forString. I got rid ofRegression.Issue215since it's now redundant and the new ones are much shorter. They're insimplerather thanregressionfor two reasons. First,tcpTestis available there, and second because theStringone isn't a regression and it doesn't make sense to split the pair.